Some questions:
- How is this supposed to work with localization? I notice your quick form implementation wraps the indicator titles in
$this->t(), but the convention specification doesn’t say anything about translated indicator quantity labels being permissible. - The specification seems light on whether all the indicators are required for every log. Obviously not populating any of them would impact the score right? Presumably, if not all indicators are required, then this creates an implicitly allowed extra value of zero - even though the spec says only 1 - 5 are allowed.
- It is surprising to me that the “purpose” section of the convention specification describes how the overall score is calculated, but that formula is not repeated with a “MUST” in the actual “specification” section.