"New log" button when viewing an asset

pat · November 17, 2022, 7:02pm

Tiny detail to consier:

When viewing an asset the “New activity log” Button/dropdown is only visible when viewing the asset info. If I view the registered logs for the asset, the button disappears.

I can’t see any reason for this.

I have my animal assets listed as url’s in a Node-Red dashboard. The url’s point me directly to the assets log view. Would be perfect to create new ones from there.

mstenta · November 17, 2022, 7:16pm

Agreed @pat that would be good!

This is the class that handles adding those links, if I remember correctly: farmOS/FarmActions.php at 2.x · farmOS/farmOS · GitHub

It may just require a minor tweak to make it appear where you describe.

Somewhere around these lines maybe?

github.com

farmOS/farmOS/blob/03279969ab3dffc291b17033b801e2bff7432139/modules/core/ui/action/src/Plugin/Derivative/FarmActions.php#L124


      
          $name = 'farm.add.' . $type . '.bundle';
          $this->derivatives[$name] = $base_plugin_definition;
          $this->derivatives[$name]['route_name'] = 'entity.' . $type . '.add_form';
          $this->derivatives[$name]['class'] = 'Drupal\farm_ui_action\Plugin\Menu\LocalAction\AddEntity';
          $this->derivatives[$name]['entity_type'] = $type;
          
          
// Add the entity_bundles cache tag so action links are recreated after
          // new bundles are installed.
          $this->derivatives[$name]['cache_tags'] = ['entity_bundles'];
          
          
// Add it to entity bundle Views, if the farm_ui_views module is enabled.
          if ($this->moduleHandler->moduleExists('farm_ui_views')) {
            $this->derivatives[$name]['appears_on'][] = 'view.farm_' . $type . '.page_type';
            $this->derivatives[$name]['bundle_parameter'] = 'arg_0';
          }
          
          
// Generate links to [entity-type]/add/[bundle]?asset=[id] on asset pages.
          if ($type == 'log') {
            $bundles = $this->entityTypeBundleInfo->getBundleInfo('log');
            foreach ($bundles as $bundle => $bundle_info) {
              $name = 'farm.asset.add.' . $type . '.' . $bundle;

mstenta · November 17, 2022, 7:21pm

Actually maybe this is the line that needs to be modified/appended to: farmOS/FarmActions.php at 03279969ab3dffc291b17033b801e2bff7432139 · farmOS/farmOS · GitHub

mstenta · November 18, 2022, 1:46pm

I gave this a quick try and got it working! Easy!

The only thing that isn’t perfect about it, is that when you click on one of the sub-tabs for a specific log type (eg: “Observations” in the screenshot above), it includes buttons for ALL logs types, not just the type you are viewing. Ideally I think it would just show “Add Observation Log” when you were viewing Observation logs of an asset.

I’m not sure if there’s an easy way to do that, though. I’ll open a PR for this and see if @paul121 has any clever ideas that I might be overlooking. If not, I think this is better than nothing - do you agree @pat ?

mstenta · November 18, 2022, 1:51pm

pat · November 18, 2022, 10:43pm

Nice.

Not sure tho, if it’s a problem. The button stays the same, and you find the add log list presented the usual way… I’d say it’s a 50/50

Or you could throw in an option to have all logs in the dropdown, but the corresponding log-type on top? I don’t know whats best… After all I’m just a simple farmer

It’s way better than nothing. I’m happy with this!!

mstenta · November 19, 2022, 12:27am

I thought of this too! Might be possible…

Happy to say that we merged the PR - now we can refine it.

Topic		Replies	Views
Asset buttons does not come Development	1	268	April 26, 2021
Can't use New Asset or Log Types? Using farmOS	1	344	April 1, 2020
Editing Asset Navigation Menu Using farmOS	9	338	March 17, 2021
Missing logs when browsing API Using farmOS support-request	1	163	October 30, 2022
Add buttons in views Using farmOS	3	367	January 27, 2021

"New log" button when viewing an asset

Related topics